Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): use ffa base ms on starcraft(2) #5207

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Dec 14, 2024

ready for review but not for merge!

Summary

Use the FFA MS Base Module in the sc(2) ffa display.

  • make columns in the base ffa ms customizable via a parser
  • adjust brkts/wikispecific on both sc and sc2 to use horizontallist for ffa matches and "redirect" Module:MatchSummary/Ffa to the one on commons
  • add a match schedule widget to be used if dates of all games of a match and the match are the same
  • kick the sc(2) singlematch overwrite (not needed anymore)

before merge but after approval

  • switch single ffa matches to bracket/2 (~100 usages, several can be bot edited)
    • list of pages with ffa matches
    • bot run to catch most: python pwb.py replace -lang:starcraft2 -transcludes:SingleFFAMatch -regex "\{\{[sS]ingleFFAMatch" "{{Bracket|Bracket/2" -summary:"prep ffa matches"
    • after the bot run kick the redirect from Template:SingleFFAMatch to Template:SingleMatch on sc2
  • improve the error on single match for ffa stuff (not intended to be used!)
    • possibly let single match template set a value that indicates it is a single match so we can just let it error in input processing already

How did you test this change?

https://liquipedia.net/starcraft2/User:Hjpalpha/wip15

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Dec 14, 2024

@Rathoz
what do you think of
image
together with
image
to ensure that on sc(2) ffa stuff is not used in combination with SingleMatch

it errors anyways, so my idea was to improve the error message

@hjpalpha hjpalpha requested a review from Rathoz December 14, 2024 18:31
@hjpalpha hjpalpha marked this pull request as ready for review December 14, 2024 18:31
@hjpalpha hjpalpha requested a review from Rathoz December 16, 2024 12:40
@Rathoz
Copy link
Collaborator

Rathoz commented Dec 18, 2024

Screenshot_20241218-171909

@hjpalpha
Copy link
Collaborator Author

IMG_4315
IMG_4316

@hjpalpha hjpalpha marked this pull request as draft December 18, 2024 18:48
@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Dec 19, 2024

Screenshot_20241218-171909

  1. done
  2. not showing placement points at all (they do not exist, there are only (sometimes) general map points, unrelated to the placement the opponent made in that map, usually the placement is rather determined from the points if they exist at all)

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Dec 19, 2024

still to do: port id stuff to widgetContexts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants