Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): always populate game and match dates #5221

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Dec 18, 2024

Summary

Resolves #5222

Depends on #5210, #5215, #5207 (this should also fix the golden warnings)

Ensure that both Match and Game Dates are set, by crosspollinating between the two, even when there's only one of the two in the input.

  • Match Date will be parsed from the match's input of field date. If the field is not supplied, fallback to use the earliest game's date.
  • Game Date will be parsed from the game's input of field date. If the field is not supplied, fallback to use the match's date.
  • Auto finished for long live matches has been changed:
    • If there is at least one Game, check that all Games have been "live long enough".
    • If there are no Games, the old logic of that the match has been "live long enough".

How did you test this change?

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@Rathoz Rathoz force-pushed the m2-game&match-dates branch from ef25e95 to 3e669ca Compare December 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match date for battle royale matches is empty
2 participants