fix(infobox): return false instead of nil for custom Publisherpremier

[Hesketh2]

Summary

Several wikis uses a different param for highlighted tiers (e.g. riotpremier valve-sponsored) which means a local implementation

these wikis apparently returns nil if its unset, in #4852 after the TeamCard Storage changes publishertier storage to false which meant now if it returns nil = it causes the highlight to triggered anyway

Side Note

There are wikis that still returns nil but the issue does not occured (e.g. Dota2) I will leave those untouched

[Hesketh2]

added all the wikis I could find, please check on the fixes for LoL and Warcraft if possible since they seem different from the rest by the original setup and I'm not sure if theres further fixes needed (the current fix revision already solves the problem)

Some wikis do return nil like Dota2, but the issue isnt popping over there so I didnt touch it

[hjpalpha]

on several wikis you just slap Logic.readBool on it
there we need to check what values are stored there currently
like it could be that some wikis have string inputs there

• brawlstars
• cod
• crossfire
• fortnite
• halo
• naraka
• pkmn
• pubg
• pubgm

i will write you a small module on commons for it
but you will have to do the leg work (previewing stuff per the above listed wikis and reporting on the results)

for warcraft it might be better to use or ''

[hjpalpha]

preview {{#invoke:CheckPublisherTier|run}} on any page of each of the above listed wikis
if you get a result other than an empty string please report it here (naming the wiki and the output)

[Hesketh2]

For all wikis (except CS/warcraft) that is recieving fixed in this PR: the module returns no text, so its empty

League of Legends returns: 1 due to the code setup still mentions "1" from the original setup

trying or '' for warcraft runs into the same current issue as counterstrike, Highlight always appears on infobox even if parameter is never exist in the page

edit: Counterstrike returns the following
Major Championship; Major Qualifier; Minor Championship; RMR Event; Tier 1; Tier 1 Qualifier; Tier 2; Tier 2 Qualifier; Wildcard

so I would need a fix for the always showing highlight when or '' is used,

[hjpalpha]

so I would need a fix for the always showing highlight when or '' is used,

you have 3 options:

• use or '' and overwrite the highlight function in the infobox on those wikis
• use or nil and overwrite the storage part in the infobox on those wikis
• use or nil and adjust the commons function for storage to Logic.isNotEmpty(self.data.publishertier) and tostring(self.data.publishertier) or ''

[hjpalpha]

League of Legends returns: 1 due to the code setup still mentions "1" from the original setup

maybe make sure that no module/template/... conditions on that

[hjpalpha]

For all wikis (except CS) that is recieving fixed in this PR: the module returns no text, so its empty

warcraft has several values there too fwiw

[Hesketh2]

so I would need a fix for the always showing highlight when or '' is used,

you have 3 options:

• use or '' and overwrite the highlight function in the infobox on those wikis
• use or nil and overwrite the storage part in the infobox on those wikis
• use or nil and adjust the commons function for storage to Logic.isNotEmpty(self.data.publishertier) and tostring(self.data.publishertier) or ''

for warcraft i'm trying the first options but surely I didnt do it correctly (since WC and CS had a very unique setup that I would be clueless at, so pasting this function is the only way I know) https://liquipedia.net/warcraft/index.php?title=Module%3AInfobox%2FLeague%2FCustom%2Fdev%2Fh2&type=revision&diff=943825&oldid=943818 (This would likely required different approach on CS given CS has even more complicated setup with Valve Tiers)

[hjpalpha]

discord discussion:

as seen there imo as a temp solution change commons storage to:
lpdbData.publishertier = tostring(self.data.publishertier or '')
that way you do not harm any wikis
and we win some time to do a proper discussion about what to do with the field