Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publishertier): store empty instead of stringified false #4915

Merged
merged 3 commits into from
Oct 19, 2024
Merged

fix(publishertier): store empty instead of stringified false #4915

merged 3 commits into from
Oct 19, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 19, 2024 •
edited
Loading

Summary

suggestion as per discussion on discord and in #4911

additionally we should set the topic publishertier for the next modules sync meeting

How did you test this change?

goldens

iMarbot
iMarbot approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is preferred solution for me anyway.

@hjpalpha
Copy link
Collaborator Author

imo rfm
mind i will still do a cleanup for the customs in the upcoming days to check which ones can be simplified

@Rathoz Rathoz merged commit 4e2af6e into main Oct 19, 2024
5 checks passed
@Rathoz Rathoz deleted the hjpalpha-patch-1 branch October 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbergen mbergen mbergen approved these changes

@iMarbot iMarbot iMarbot approved these changes

@Rathoz Rathoz Rathoz approved these changes

@Hesketh2 Hesketh2 Awaiting requested review from Hesketh2

Assignees
No one assigned
Labels
c: infobox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hjpalpha @Rathoz @iMarbot @mbergen