Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): clash royale support #4321

Merged
merged 35 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
231ed81
Adding MVPs to Clash Royale. Also adding misisng
FenrirWulf Jun 7, 2024
0ec0374
Minor Linter fixes, and renaming file
FenrirWulf Jun 7, 2024
8dea5c8
MGIC linter fixes and minor refactors
FenrirWulf Jun 7, 2024
7d6172c
EOF empty line, since VSC doesnt seem to want to push it
FenrirWulf Jun 7, 2024
aac21e4
FIxing typo
FenrirWulf Jun 9, 2024
14cf71f
Merge branch 'CR-M2-MVPs' of https://github.com/Liquipedia/Lua-Module…
FenrirWulf Jun 9, 2024
490bc98
Code Cleanup
FenrirWulf Jun 11, 2024
1668045
Using commons version
FenrirWulf Jun 14, 2024
3b87147
Adding annotations
FenrirWulf Jun 14, 2024
c9b6fe6
Trailing whitespace
FenrirWulf Jun 14, 2024
8842e6b
Converting to array
FenrirWulf Jun 30, 2024
90a27a8
Minor rewrites for Summary
FenrirWulf Jul 4, 2024
702199d
Batch changes
FenrirWulf Jul 4, 2024
f250ec5
Casters & Array stuff
FenrirWulf Jul 4, 2024
05bb294
Removing MVPs for new PR
FenrirWulf Jul 13, 2024
2fe1538
Adjusting for invalid card input
FenrirWulf Jul 16, 2024
36c6fff
Code cleanup
FenrirWulf Jul 17, 2024
ef2b8aa
minor code cleanup
FenrirWulf Jul 22, 2024
0354b69
some cleanup
hjpalpha Aug 1, 2024
f438a4b
kick trailing white space
hjpalpha Aug 2, 2024
a2731c7
only allow walkovers via score inputs
hjpalpha Aug 2, 2024
cb464a0
adjust for stupid bs tower cards
hjpalpha Aug 3, 2024
847f767
fix: do the pagify after retrieving players
hjpalpha Aug 5, 2024
94918d3
refactor mgi
hjpalpha Sep 3, 2024
eeca984
kick unused
hjpalpha Sep 3, 2024
aa094a4
Merge branch 'main' into CR-M2-MVPs
hjpalpha Sep 4, 2024
7c1503a
fix
hjpalpha Sep 4, 2024
b210691
pass correct var to `mapIsFinished`
hjpalpha Sep 4, 2024
dc6aa50
Update components/match2/wikis/clashroyale/match_group_input_custom.lua
hjpalpha Sep 9, 2024
1cf460d
Merge branch 'main' into CR-M2-MVPs
hjpalpha Sep 10, 2024
2113199
#4650
hjpalpha Sep 10, 2024
fe67332
from review
hjpalpha Sep 18, 2024
cb90d58
Merge branch 'main' into CR-M2-MVPs
hjpalpha Sep 18, 2024
3a5d138
not needed
hjpalpha Sep 18, 2024
31dcf37
Update components/match2/wikis/clashroyale/match_group_input_custom.lua
hjpalpha Sep 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions components/match2/wikis/clashroyale/match_summary.lua
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,21 @@ function CustomMatchSummary._createGame(game, gameIndex, date)
date = date,
})

-- Add Match MVP(s)
if match.extradata.mvp then
local mvpData = match.extradata.mvp
if not Table.isEmpty(mvpData) and mvpData.players then
local mvp = MatchSummary.Mvp()
for _, player in ipairs(mvpData.players) do
mvp:addPlayer(player)
end
mvp:setPoints(mvpData.points)

body:addRow(mvp)
end

end

-- Add Comment
if not Logic.isEmpty(game.comment) then
row:addElement(MatchSummary.Break():create())
Expand Down
Loading
Loading