-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(match2): clash royale support #4321
Conversation
file to the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter is complaining quite a bit too
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
Yeah.. im working through it now. The MatchGroup Input is going to be a pain to rewrite. Plus missing all annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the input module is far of from standard
you can make use of several commons functions for sure
additionally it needs lots of cleanup
and annotations missing entirely
only skimmed through the first 150 lines (am on mobile)
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/matchgroup_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionally check if Module:CharacterIcon
can be used in the display (MatchSummary)
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
isnt it already being imported on line 3? |
needs retesting! |
Pasting over onto |dev=1 - https://liquipedia.net/clashroyale/index.php?title=User:Hesketh2/test&action=edit&redlink=1 Seems working with the submatch variation but not as for Solo/Duos with cards |
components/match2/wikis/clashroyale/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
Co-authored-by: Rikard Blixt <[email protected]>
#4650 adjustment needed |
Summary
Add CR MGI
How did you test this change?
dev (there is a non git version running on the wiki currently ...)