Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Transfer): Add Transfer components #4222

Merged
merged 82 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
23208e8
start
hjpalpha Apr 25, 2024
90f8b27
more transfer list
hjpalpha Apr 25, 2024
a1aca74
transfer list
hjpalpha Apr 25, 2024
8ee866e
Merge branch 'main' into transfer
hjpalpha Apr 25, 2024
e50b579
shut up linter
hjpalpha Apr 25, 2024
e8d3322
basic structure
hjpalpha Apr 25, 2024
226ed94
fix return
hjpalpha Apr 25, 2024
db73848
unused
hjpalpha Apr 25, 2024
0d13280
some more
hjpalpha Apr 26, 2024
6db02c6
more
hjpalpha Apr 26, 2024
691e3ab
use module:Info
hjpalpha Apr 26, 2024
7886146
position and icons
hjpalpha Apr 26, 2024
2b8c3f4
make TransferRowDisplay a class
hjpalpha Apr 28, 2024
e56a98e
tmp
hjpalpha Apr 28, 2024
b5b254d
rest of display?
hjpalpha Apr 28, 2024
2d73696
unused
hjpalpha Apr 28, 2024
1253bcf
not needed (i think)
hjpalpha Apr 28, 2024
4a28b5b
fixes: transferList
hjpalpha Apr 29, 2024
722ab94
fix: transferRow
hjpalpha Apr 29, 2024
e064a34
more fixes
hjpalpha Apr 29, 2024
0871d2f
faction redirect customs
hjpalpha Apr 29, 2024
544f257
deepMergeInto misbehaving
hjpalpha Apr 29, 2024
3a90083
display fixes
hjpalpha Apr 29, 2024
8c6a0d7
fix `allRef` check
hjpalpha Apr 29, 2024
c564fca
use #4235
hjpalpha Apr 29, 2024
3b8a32f
remove redundant
hjpalpha Apr 30, 2024
d9d23ca
as per discussion remove need for several configs
hjpalpha Apr 30, 2024
da641d7
Merge branch 'main' into transfer
hjpalpha Apr 30, 2024
694024f
linter: unused vars
hjpalpha Apr 30, 2024
13b3827
Merge branch 'transfer' of https://github.com/Liquipedia/Lua-Modules …
hjpalpha Apr 30, 2024
123c797
ref stuff to json based (untested)
hjpalpha Apr 30, 2024
905316e
minor cleanup
hjpalpha Apr 30, 2024
73c0b7b
linter: unused import
hjpalpha Apr 30, 2024
58ecc72
re-add `platformIcons`
hjpalpha Apr 30, 2024
5f057dc
fix references
hjpalpha Apr 30, 2024
d99ab8e
info cleanup
hjpalpha Apr 30, 2024
7129cf4
kick `platformIcons` config again and use module exist condition instead
hjpalpha May 1, 2024
dc4e1cf
catch nil
hjpalpha May 2, 2024
a0721db
fix inside source ref display
hjpalpha May 2, 2024
c42cb89
icon fallback for 2nd icon
hjpalpha May 2, 2024
a37922b
use #4236 and move faction + smash extra stuff to commons
hjpalpha May 4, 2024
94ec477
remove iconParam option as per last change (tf2 gets forced to use `p…
hjpalpha May 4, 2024
3cd6d87
kick showTeamName option and enforce it always
hjpalpha May 4, 2024
61b788a
simplify
hjpalpha May 4, 2024
78aa6f8
Merge branch 'main' into transfer
hjpalpha May 5, 2024
5d10792
rename function in custom
hjpalpha May 5, 2024
2688ee0
start on adding rumour stuff
hjpalpha May 5, 2024
3a1527a
rumour stuff
hjpalpha May 5, 2024
ed13f89
move references handling to extra module
hjpalpha May 17, 2024
8857f9e
use `Module:Transfer/Refences` in squads
hjpalpha May 17, 2024
9cce2ce
not needed
hjpalpha May 17, 2024
3283760
Update transfer_row_display.lua
hjpalpha Jun 6, 2024
f849086
pos icon adjust as per module sync discussion
hjpalpha Jun 7, 2024
5de4f0d
as per modules sync discussion
hjpalpha Jun 7, 2024
60c64c7
as per review
hjpalpha Jun 13, 2024
19029c1
unify retirement and retired to just retired
hjpalpha Jun 13, 2024
445671c
use curry (as per review suggestion)
hjpalpha Jun 13, 2024
b470458
fix as per review
hjpalpha Jun 13, 2024
53c1e0b
typo
hjpalpha Jun 13, 2024
b2cccf0
shut up linter
hjpalpha Jun 13, 2024
665bb42
as per review
hjpalpha Jul 12, 2024
c29c510
as per modules sync discussion
hjpalpha Aug 1, 2024
9d33fb3
as per review
hjpalpha Aug 21, 2024
603b4b1
deduplicate
hjpalpha Aug 21, 2024
d122a3a
Revert "deduplicate"
hjpalpha Aug 21, 2024
1875ea1
deduplicate a bit
hjpalpha Aug 21, 2024
5fff485
Merge branch 'main' into transfer
hjpalpha Sep 11, 2024
fdfa2a4
as per comment by saltt
hjpalpha Sep 11, 2024
6cc5061
Merge branch 'transfer' of https://github.com/Liquipedia/Lua-Modules …
hjpalpha Sep 11, 2024
db71589
Merge branch 'main' into transfer
hjpalpha Oct 7, 2024
cdcb85e
Merge branch 'main' into transfer
hjpalpha Oct 14, 2024
c73ccd2
suppress false positive anno warnings
hjpalpha Oct 14, 2024
36ba3f2
start a test case
hjpalpha Oct 14, 2024
18a7afc
more test stuff
hjpalpha Oct 14, 2024
2326556
from review
hjpalpha Oct 14, 2024
2d3e5de
Merge branch 'main' into transfer
hjpalpha Oct 15, 2024
fe003e8
use correct path
hjpalpha Oct 15, 2024
9c97087
fix typo
hjpalpha Oct 15, 2024
a2ccfee
normalize flag & faction storage value
hjpalpha Oct 15, 2024
d9e7f89
fix some test stuff
hjpalpha Oct 15, 2024
cedb4a7
break line
hjpalpha Oct 15, 2024
0a90a81
fix typo
hjpalpha Oct 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/transfer/commons/transfer_list.lua
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ function TransferList:parseArgs(args)
local roles = Array.parseCommaSeparatedString(args.role)

local sortOrder = args.order or DEFAULT_VALUES.order
local objectNameSortOrder = 'asc'
local objectNameSortOrder = 'desc'
if sortOrder:lower() == 'asc' then
objectNameSortOrder = 'desc'
objectNameSortOrder = 'asc'
end
hjpalpha marked this conversation as resolved.
Show resolved Hide resolved

return {
Expand Down
5 changes: 2 additions & 3 deletions components/transfer/commons/transfer_row_custom.lua
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ end
---@param frame Frame
---@return Html?
function CustomTransferRow.rumour(frame)
local args = Arguments.getArgs(frame)
args.isRumour = true
return CustomTransferRow(args):read():store():build()
frame.args.isRumour = true
return CustomTransferRow.transfer(frame)
end

return CustomTransferRow
Loading