feat(Transfer): Add Transfer components #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 603b4b1.
|
needs retesting |
mbergen
reviewed
Aug 21, 2024
|
retested fwiw |
Rathoz
approved these changes
Oct 7, 2024
|
Could you add some tests? At least some smoke/golden test? |
Rathoz
reviewed
Oct 14, 2024
|
Make sure to add the transfer_list folder to test_helper.lua |
|
yeah will continue tomorrow |
Rathoz
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Transfer components
transfer list
transfer row
transfer row display
Allows to kill all wikispecific
Transfer RowandTransfer Listtemplates that use the currentModule:Transfer/Module:Transfer List.Allows to kick the transferWrapper Modules currently used to enable syncPlayer (indirectly)
Integrates Rumour Row into transferRow module. (making it darkmode compliant on all wikis & standardizing it too)
How did you test this change?
After merge but before rollout:
push the following to live (so switching stuff over does not break anything):
Follow-Up PR:
After everything was rolled out (and purged) remove the deprecated function
TransferRef.fromLegacyStorageDataand its usage inTransferRef.fromStorageData