Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 shinythemes not finding themes #24

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

Jiaro
Copy link
Collaborator

@Jiaro Jiaro commented Mar 20, 2022

No description provided.

@Jiaro Jiaro requested a review from LamaTe March 20, 2022 22:27
@Jiaro Jiaro linked an issue Mar 21, 2022 that may be closed by this pull request
@LamaTe
Copy link
Owner

LamaTe commented Mar 27, 2022

Thanks for spotting this and linking the external GitHub issue. Nice!

Unfortunately, this fix does not work entirely on my machine (Linux). Following bugs:

  • When using bslib, the cerulan theme is not fully applied or at least fonts etc. look much different, bigger and other spacing.
  • In Learner tab upon creation of first learner, the Learner panel on right side is not displayed.

Is this also the case on your machine?

@Jiaro
Copy link
Collaborator Author

Jiaro commented Apr 10, 2022

Hey, upon checking the UI again you are absolutely right, the fonts look bigger and the spacings are not right.
When testing your second point, the same issue happens to me, and if you create a second learner and switch between the two tabs on the right side the overview for the first learner appears again, just like you mentioned in discord.
This is beyond weird and probably not linked to our development, since we only changed the theme, maybe a version issue regarding bootstrap and shiny? But at this point im just guessing...

@LamaTe LamaTe merged commit e6c9176 into master Apr 18, 2022
@LamaTe LamaTe deleted the 23-shinythemes-not-finding-themes branch April 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shinythemes not finding themes
2 participants