Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci with mamba to support the stack #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions .github/workflows/python-app.yml → .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,39 @@ on:
branches: [ main ]

jobs:
build:

lsst-tests:
name: tests
strategy:
matrix:
pyver: [3.8]
runs-on: ubuntu-latest

steps:
- name: Cancel Previous Runs
uses: styfle/[email protected]
with:
access_token: ${{ github.token }}
- uses: actions/checkout@v2
- name: Set up Python 3.8
uses: actions/setup-python@v2
- uses: conda-incubator/setup-miniconda@v2
with:
python-version: "3.8"
python-version: ${{ matrix.pyver }}
channels: conda-forge,defaults
channel-priority: strict
show-channel-urls: true
- name: Install dependencies
shell: bash -l {0}
run: |
python -m pip install --upgrade pip
python -m pip install --upgrade pytest
python -m pip install flake8 pytest pytest-cov coveralls
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi

conda config --set always_yes yes
conda install --quiet --yes mamba
mamba install --quiet --yes --file requirements.txt
mamba install -q -y stackvana=0 lsstdesc-weaklensingdeblending

pip install --no-deps git://github.com/sibirrer/lenstronomy.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I would install the pypi version of lenstronomy rather than the main branch on the GitHub repo.
I am not even sure this is required since in the requirements.txt file you have already set a requirement to lenstronomy (pypi version)

pip install --no-deps git://github.com/LSSTDESC/gcr-catalogs.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for lenstronomy concerning the mentioning in the requirements.txt file.
Then this line seems to be where GitHub Actions fail (but I guess in mamba through requirements.txt. It might be due to install_requires[] for the GCRCatalogs package in their setup.py file or simply because there is no anaconda or pypi version. Do you know whether some other DESC specific packages is using this package and does GitHub Actions/CI using it?


python -m pip install .
- name: Lint with flake8
run: |
Expand Down