Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci with mamba to support the stack #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci with mamba to support the stack #3

wants to merge 1 commit into from

Conversation

herjy
Copy link
Collaborator

@herjy herjy commented May 10, 2022

This version of the tests uses a mamba environment that already has the stack installed. I don't really understand how that works, but it seems to use the WeakLensingDeblending package.

@herjy herjy added the help wanted Extra attention is needed label May 10, 2022
@herjy herjy requested a review from sibirrer May 10, 2022 23:46
Copy link

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @herjy for the PR! I made two comments about possible problems. It seems that it is the GCRCatalogs() package that causes troubles and not lenstronomy. Since GCRCatalogs() is in the DESC stacks (I would guess), we might request help from the developers. I could also experiment if you want. Let me know!

mamba install --quiet --yes --file requirements.txt
mamba install -q -y stackvana=0 lsstdesc-weaklensingdeblending

pip install --no-deps git://github.com/sibirrer/lenstronomy.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I would install the pypi version of lenstronomy rather than the main branch on the GitHub repo.
I am not even sure this is required since in the requirements.txt file you have already set a requirement to lenstronomy (pypi version)

mamba install -q -y stackvana=0 lsstdesc-weaklensingdeblending

pip install --no-deps git://github.com/sibirrer/lenstronomy.git
pip install --no-deps git://github.com/LSSTDESC/gcr-catalogs.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for lenstronomy concerning the mentioning in the requirements.txt file.
Then this line seems to be where GitHub Actions fail (but I guess in mamba through requirements.txt. It might be due to install_requires[] for the GCRCatalogs package in their setup.py file or simply because there is no anaconda or pypi version. Do you know whether some other DESC specific packages is using this package and does GitHub Actions/CI using it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants