Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --ocm-hub flag and update bundle #403

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

adam-cattermole
Copy link
Member

Policy controller pod was failing to start due to additional --ocm-hub flag which was removed (see Kuadrant/multicluster-gateway-controller#711).

Manifests also needed updating from make bundle

@adam-cattermole adam-cattermole requested a review from a team as a code owner January 23, 2024 15:16
@adam-cattermole adam-cattermole self-assigned this Jan 23, 2024
@adam-cattermole adam-cattermole changed the title Remove -ocm-hub flag and update bundle Remove --ocm-hub flag and update bundle Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #403 (80c5dc5) into main (624f58b) will decrease coverage by 0.58%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   66.50%   65.93%   -0.58%     
==========================================
  Files          38       38              
  Lines        3863     3901      +38     
==========================================
+ Hits         2569     2572       +3     
- Misses       1110     1141      +31     
- Partials      184      188       +4     
Flag Coverage Δ
integration 70.75% <ø> (-1.20%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.75% <ø> (-1.20%) ⬇️

see 4 files with indirect coverage changes

Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👷🏼

@adam-cattermole adam-cattermole merged commit d8c4f6a into Kuadrant:main Jan 24, 2024
16 checks passed
@adam-cattermole adam-cattermole deleted the remove-ocm-hub branch January 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants