Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of sail to nightly 18-01-2024 #402

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

adam-cattermole
Copy link
Member

I have pinned the version of the sail operator to the commit prior to the kustomize manifests being removed: https://github.com/maistra/istio-operator/config/default?ref=b7f5286be0bc25cb257bc439e7c18acb99dce26f.

Test install locally:

ISTIO_INSTALL_SAIL=true make local-setup

Check deployment is using correct image:

kubectl get deployment istio-operator -n istio-system -o yaml | yq '.spec.template.spec.containers | filter(.name == "manager") | .[0].image'
# quay.io/maistra-dev/istio-operator:3.0-nightly-2024-01-18

Resolves #382

@adam-cattermole adam-cattermole self-assigned this Jan 23, 2024
@adam-cattermole adam-cattermole requested a review from a team as a code owner January 23, 2024 14:52
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #402 (6aa6189) into main (d8c4f6a) will decrease coverage by 0.93%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   66.50%   65.57%   -0.93%     
==========================================
  Files          38       38              
  Lines        3863     3901      +38     
==========================================
- Hits         2569     2558      -11     
- Misses       1110     1152      +42     
- Partials      184      191       +7     
Flag Coverage Δ
integration 70.06% <ø> (-1.89%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.06% <ø> (-1.89%) ⬇️

see 7 files with indirect coverage changes

This was referenced Jan 23, 2024
@adam-cattermole
Copy link
Member Author

Bundle is fixed in #403, once merged I'll rebase

Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
/lgtm

@adam-cattermole adam-cattermole merged commit 2c2d5dc into Kuadrant:main Jan 25, 2024
15 checks passed
@adam-cattermole adam-cattermole deleted the pin-sail-version branch January 25, 2024 14:31
adam-cattermole added a commit to adam-cattermole/kuadrant-operator that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pin version of Sail used
2 participants