Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate frontend to yarn 4 #71

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Migrate frontend to yarn 4 #71

merged 2 commits into from
Oct 24, 2023

Conversation

carlos-kryha
Copy link
Contributor

Description

Since we are no longer tracking frontend/.yarn/, and yarnrc.yml points to it, yarn breaks.

Coincidentally, yarn 4 just landed and it seems to solve the issue with Corepack:

"...we used to recommend using the yarnPath setting pointing to a checked-in binary, but this pattern increased friction more than we liked - many people didn't like the idea of adding a binary to their repository, however small. We listened, and worked conjointely with Node.js on a project called Corepack. Corepack is a tool shipped with Node.js 16+ that will automatically select the right package manager version to run depending on the project you're working on"

Acceptance Criteria

  • yarn does not depend on /frontend/.yarn
  • [] QAd

@carlos-kryha carlos-kryha merged commit 6a4b5ba into develop Oct 24, 2023
2 checks passed
@carlos-kryha carlos-kryha deleted the frontend/upgrade-yarn branch October 24, 2023 13:57
carlos-kryha added a commit that referenced this pull request Nov 10, 2023
Includes the following work:
- #81 
- #77 
- #71 
- #70 
- #69 
- #67 
- #66 
- #63 (note this update requires a core-eval proposal to take effect)

QA is tracked
[here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing)

---------

Co-authored-by: Privilege Mendes <[email protected]>
Co-authored-by: Axel Verheul <[email protected]>
Co-authored-by: Xabier <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Wietze <[email protected]>
Co-authored-by: Xabier Almazor Telek <[email protected]>
Co-authored-by: Nick K <[email protected]>
Co-authored-by: Nick Koster <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: MangoDream1 <[email protected]>
Co-authored-by: Synthetics <[email protected]>
snthtcs added a commit that referenced this pull request Nov 13, 2023
Includes the following work:
- #81 
- #77 
- #71 
- #70 
- #69 
- #67 
- #66 
- #63 (note this update requires a core-eval proposal to take effect)

QA is tracked
[here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing)

---------

Co-authored-by: Privilege Mendes <[email protected]>
Co-authored-by: Axel Verheul <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Wietze <[email protected]>
Co-authored-by: CARLOS TRIGO <[email protected]>
Co-authored-by: Xabier Almazor Telek <[email protected]>
Co-authored-by: Nick K <[email protected]>
Co-authored-by: Nick Koster <[email protected]>
Co-authored-by: carlos-kryha <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: MangoDream1 <[email protected]>
Co-authored-by: Synthetics <[email protected]>
Co-authored-by: Synthetics <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants