Frontend fixes and improvements #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Fixed connect-wallet issue on the activate wallet page - [x] Removed blur filter from the character detail section in the landing page  - [x] removed item counters from category mode  - [x] removed all mobile ui ( moved to mobile branch) --------- Co-authored-by: Axel Verheul <[email protected]>
This PR introduces GitHub Actions pipelines into the Kread Frontend repository's workflow, enabling automated deployment to both the Emerynet and Mainnet environments. - PR -> develop (requires approver) -> Deploys to Emerynet on PR closed - develop -> PR -> main (requires approver from CODEOWNERS) -> Deploys to Mainnet on PR closed CODEOWNERS: - @carlos-kryha - @WietzeSlagman --------- Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Wietze <[email protected]> Co-authored-by: CARLOS TRIGO <[email protected]> Co-authored-by: Xabier Almazor Telek <[email protected]>
Fixes issue #35. This PR makes the button clickable instead of the text. Co-authored-by: Nick Koster <[email protected]>
This enebles us to exclude certain category/rarity combinations from the item shop. Currently excluding legendary hair items due to #53 - [x] cleaned up item-shop data - [x] added const for filtering out by `[[Category, Rarity[]]]` - [x] implemented filters in item-shop - [x] update view --------- Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Wietze <[email protected]> Co-authored-by: Xabier Almazor Telek <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]> Co-authored-by: Axel Verheul <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]>
Add spread operator to array to fix error Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Fixed marketplaceAverageLevel metric. For items, this metric was being calculated incorrectly. This lead to specific cases where the metric might become a negative value after updating. This would violate the typeguard of the metric which expects it to be greater or equal than 0 and an error would be thrown. This means the buy item flow would not complete hence why the item would still remain in the market state. Fixes 2 bugs: 1. #61 2. #53 Co-authored-by: Pandelis Symeonidis <[email protected]>
- Fixed the placement of confirm and previous buttons in sell modal (for items and characters). Wrapped the buttons in wrapper and made the step components a bit smaller so the buttons can fit nicely at the bottom. - Removed padding from some arrow icons in the button so they show up properly closes #64 Co-authored-by: Pandelis Symeonidis <[email protected]>
…67) Switch to MAIN interaction mode when clicking the sell button in the character-mode. closes #65 Co-authored-by: Pandelis Symeonidis <[email protected]>
Removed all the .yarn cache files from git; so they are no longer tracked; now it should be ignored like specified in the gitignore Co-authored-by: Axel Verheul <[email protected]>
- Removed the `X` tag from error messages in the contract. This ensures the error message is also returned to the makeOffer call. Now we can match on the error message and display an appropriate error to the user. closes #68 Co-authored-by: Pandelis Symeonidis <[email protected]>
### Description Since we are no longer tracking `frontend/.yarn/`, and [yarnrc.yml](https://github.com/Kryha/KREAd/blob/develop/frontend/.yarnrc.yml) points to it, yarn breaks. Coincidentally, [yarn 4](https://yarnpkg.com/blog/release/4.0) just landed and it seems to solve the issue with Corepack: > "...we used to recommend using the [yarnPath](https://yarnpkg.com/configuration/yarnrc#yarnPath) setting pointing to a checked-in binary, but this pattern increased friction more than we liked - many people didn't like the idea of adding a binary to their repository, however small. We listened, and worked conjointely with Node.js on a project called [Corepack](https://nodejs.org/api/corepack.html). Corepack is a tool shipped with Node.js 16+ that will automatically select the right package manager version to run depending on the project you're working on" ### Acceptance Criteria - [x] yarn does not depend on `/frontend/.yarn` - [x] QAd
Co-authored-by: Xabier <[email protected]> Co-authored-by: Xabier Almazor <[email protected]>
Fixes #78 by inverting the logo on hover.  --------- Co-authored-by: Nick Koster <[email protected]>
- [x] Pricing selector for items adjusts based on min and max prices - [x] Pricing selector for character adjusts based on min and max prices
This pull request introduces a new feature to the useNetworkConfig custom hook, providing users with a UI select button to toggle between different available networks. <img width="208" alt="image" src="https://github.com/Kryha/KREAd/assets/20317699/5c43e2da-2681-4a91-99cb-4cc281606e4a"> - [x] Network Selector available on the footer - [x] Hot reload functionality (no need to refresh the page) Additional Update: - [x] Added missing dependency to for metrics data in the shop
Branch including all frontend changes implemented in the last sprint, once [QA](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit#gid=0) is done we can PR to prod --------- Co-authored-by: Pandelis Symeonidis <[email protected]>
This PR introduces a build step pre-check on GitHub actions that will be triggered every time a new PR against develop is created. How it works: 1. Dev opens PR to develop 2. Skaffold build is triggered 3. If new modifications are done to the PR while its open step 2 is re-triggered 4. After PR is merged the normal pipeline gets executed (build+push+deploy) 5. You can't get your PR merged if the pre-check pipeline isn't green, so it needs to finish first To achieve this: - New pipeline kread-skaffold-precheck.yml - Branch protection rule at repo level --------- Co-authored-by: Synthetics <[email protected]>
QA surfaced several problems with the price filter components: - [x] Slider input is not usable with ranges > ~1000, since the steps are too big to find specific numbers > Fix: removed slider input component, added todo with potential solutions, and adjusted wrapper ui - [x] Min/max input components missing `value` property > Fix: added value property - [x] Price metrics affected by price filters > Fix: calculate price metrics using full market instead of filtered - [x] Min/max input used uIST, while all prices show IST > Fix: refactor filters to use IST - [x] Clear all does not clear price filter > Fix: refactor reset mechanism to work with clear all feature --------- Co-authored-by: Pandelis Symeonidis <[email protected]>
WietzeSlagman
approved these changes
Nov 10, 2023
Pandelissym
approved these changes
Nov 10, 2023
snthtcs
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following work:
QA is tracked here