Return meaningfull error messages from contract #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandelissym
commented
Oct 23, 2023
carlos-kryha
approved these changes
Oct 24, 2023
carlos-kryha
added a commit
that referenced
this pull request
Nov 10, 2023
Includes the following work: - #81 - #77 - #71 - #70 - #69 - #67 - #66 - #63 (note this update requires a core-eval proposal to take effect) QA is tracked [here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing) --------- Co-authored-by: Privilege Mendes <[email protected]> Co-authored-by: Axel Verheul <[email protected]> Co-authored-by: Xabier <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Wietze <[email protected]> Co-authored-by: Xabier Almazor Telek <[email protected]> Co-authored-by: Nick K <[email protected]> Co-authored-by: Nick Koster <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]> Co-authored-by: MangoDream1 <[email protected]> Co-authored-by: Synthetics <[email protected]>
snthtcs
added a commit
that referenced
this pull request
Nov 13, 2023
Includes the following work: - #81 - #77 - #71 - #70 - #69 - #67 - #66 - #63 (note this update requires a core-eval proposal to take effect) QA is tracked [here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing) --------- Co-authored-by: Privilege Mendes <[email protected]> Co-authored-by: Axel Verheul <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Xabier Almazor <[email protected]> Co-authored-by: Wietze <[email protected]> Co-authored-by: CARLOS TRIGO <[email protected]> Co-authored-by: Xabier Almazor Telek <[email protected]> Co-authored-by: Nick K <[email protected]> Co-authored-by: Nick Koster <[email protected]> Co-authored-by: carlos-kryha <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]> Co-authored-by: Pandelis Symeonidis <[email protected]> Co-authored-by: MangoDream1 <[email protected]> Co-authored-by: Synthetics <[email protected]> Co-authored-by: Synthetics <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xtag from error messages in the contract. This ensures the error message is also returned to the makeOffer call. Now we can match on the error message and display an appropriate error to the user.closes #68