Closed open issues, updated to python 3.x, fast cosmic ray removal, and PEP8 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.iteritems() is deprecated in Python 3.X
Replaced loop with print statement.
.icol() is deprecated in pandas.
Explicitly defined top, bottom, and padding variables as integers in cut_out function.
In image_lib.py, import astroscrappy but if not installed then default to original LACOSMIC
Also added logging info for cosmic ray rejection method.
...otherwise it will be printed twice in the log.
Astrodude11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dgn.py so -dgn mode is compatible with Python 3.X.
Added Cython implementation of LACOSMIC. This requires the astroscrappy package. If it's not installed then the original LACOSMIC is used. The main logger now records which implementation is used.
Closes issues 2 small bugs found using Python 2.7.12 #5, Noise image appears to underestimate the photon noise #10, Noise term in extract spectra does not always include the sky noise #11
Compliant with PEP8
Converted python 2 to 3 using 2to3 lib