[WIP] Some Python 2 -> Python 3 changes to get the rawfits demo to work #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to report that my editor automatically scrubbed some whitespace, obscuring the relatively few content changes amidst a sea of irrelevant diffs. I can probably undo that if it's a pain to see the content changes, just let me know. |
|
Whoops, I just noticed PR #8 which may duplicate the same Python 2 ➡️ 3 conversion... Should I start basing off of that PR rather than master as a Python3 user? Any guidance welcomed! |
|
I just confirmed that PR #8 indeed had no problem with Python 3, and in fact is even faster because of the cosmic ray advances. Bravo, thank you! Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To whom it may concern,
Hi! 👋
Thank you for maintaining
NSDRP🎉I encountered some error messages (omitted) while running the NSDRP rawfits demo from the documentation.
nsdrp.py -oh_filename /path/to/ir_ohlines.dat /path/to/rawfits /your/output/pathI diagnosed this error message and several others as arising from a Python 2/3 incompatibility problem. The most common problems were cases of integer division, which results in integers in python 2, and floats in python 3. I replaced instances of the division operator
/with the floor division operator//.I did not check to see if these changes maintained backwards compatibility with Python 2, so I'm submitting this Pull Request as a "work in progress", so that you all can decide how best to include these changes, if at all. In the very least, users finding this Pull Request can pull these changes.
Best wishes! 📈