Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode extension not respecting exclude #578

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix vscode extension not respecting exclude #578

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3ea332e
Fix vscode extension not respecting exclude
chriscerie Jan 13, 2024
837f3f9
Merge branch 'main' of https://github.com/chriscerie/selene into fix-…
chriscerie Mar 23, 2024
f75516e
Merge branch 'main' into fix-exclude
chriscerie Mar 23, 2024
b109c2d
Lint on files directly
chriscerie Mar 23, 2024
21a14bf
Revert lockfile
chriscerie Mar 23, 2024
cf83333
Remove space
chriscerie Mar 23, 2024
e777900
Readd space
chriscerie Mar 23, 2024
5e0bde5
Revert to manually detecting exclude
chriscerie May 25, 2024
d77bd7b
Merge branch 'main' into fix-exclude
chriscerie May 25, 2024
9fc2349
Merge branch 'main' into fix-exclude
chriscerie May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions selene-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ All notable changes to the "selene-vscode" extension will be documented in this
If you want to stay up to date with selene itself, you can find the changelog in [selene's CHANGELOG.md](https://github.com/Kampfkarren/selene/blob/master/CHANGELOG.md).

## Unreleased
- Fixed an issue where the extension wouldn't respect the config file's exclude paths.

## [1.5.1]
- selene now works with the Luau language ID.
Expand Down
6 changes: 4 additions & 2 deletions selene-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,12 @@ export async function activate(

const output = await selene.seleneCommand(
context.globalStorageUri,
"--display-style=json2 --no-summary -",
// Must use relative path for now due to https://github.com/Kampfkarren/selene/issues/593
`--display-style=json2 --no-summary ${vscode.workspace.asRelativePath(
document.uri.fsPath,
)}`,
selene.Expectation.Stderr,
vscode.workspace.getWorkspaceFolder(document.uri),
document.getText(),
)

if (!output) {
Expand Down
Loading