Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vscode extension not respecting exclude #578

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix vscode extension not respecting exclude #578

wants to merge 10 commits into from

Conversation

chriscerie
Copy link
Collaborator

@chriscerie chriscerie commented Jan 13, 2024 •
edited
Loading

The extension now lints on the files directly instead of forwarding text to let cli handle exclude.

@chriscerie chriscerie marked this pull request as ready for review March 23, 2024 20:26
Kampfkarren
Kampfkarren reviewed Apr 28, 2024
View reviewed changes
Copy link
Owner

@Kampfkarren Kampfkarren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break selene if it's in a new tab with no associated file?

@chriscerie chriscerie marked this pull request as draft April 28, 2024 22:51
@chriscerie chriscerie marked this pull request as ready for review May 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kampfkarren Kampfkarren Kampfkarren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscerie @Kampfkarren