Modernize cmake #68
Merged
Modernize cmake #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechow
force-pushed
the
modernize_cmake
branch
from
68ce025 to
84575b0
Compare
Merged
ll-nick
approved these changes
Nov 5, 2024
ll-nick
reviewed
Nov 5, 2024
| @@ -138,7 +138,7 @@ In order to compile with tests define `BUILD_TESTS=true` | |||
| mkdir -p arbitration_graphs/build | |||
| cd arbitration_graphs/build | |||
| cmake -DBUILD_TESTS=true .. | |||
| cmake --build . | |||
| cmake --build . -j9 | |||
There was a problem hiding this comment.
Kind of arbitrary, but at least more than one.
A very rough suggestion was once to use #threads + 1, nowadays 2 * #threads seems to also work for many. Anyhow, it's not too crazy to assume a modern dev has >8 threads available (4 cores with hyperthreading).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CMake cleanup and refactoring, in preparation to add the #22 as subfolder project.
Based on Modern CMake book and other sources.