Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize cmake #9

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Modernize cmake #9

merged 11 commits into from
Nov 7, 2024

Conversation

orzechow
Copy link
Member

@orzechow orzechow commented Nov 6, 2024

Following KIT-MRT/arbitration_graphs#68, this cleans up the CMake setup.

@orzechow orzechow requested a review from ll-nick November 6, 2024 14:10
@orzechow orzechow mentioned this pull request Nov 6, 2024
1 task
Copy link
Collaborator

@ll-nick ll-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot for keeping things consistent and updating things here too!

I'll approve this already but could also update the README?

  • We now have docker stages and services inside a single docker compose file
  • We don't need the find command to run all tests but can use cmake and the test target
  • The test output also look different but I would just remove that part

@orzechow
Copy link
Member Author

orzechow commented Nov 7, 2024

I'll approve this already but could also update the README?

* We now have docker stages and services inside a single docker compose file
* We  don't need the `find` command to run all tests but can use cmake and the test target
* The test output also look different but I would just remove that part

Good catch!

See a01337b

@orzechow orzechow merged commit 9869111 into main Nov 7, 2024
@orzechow orzechow deleted the modernize_cmake branch November 7, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants