-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile paths & binary files #9
base: master
Are you sure you want to change the base?
Makefile paths & binary files #9
Conversation
miquelramirez
commented
Jan 8, 2016
- Changed reference in Makefile to /src/Parser/lex.yy to src/Parser/lex.yy
- Added .gitinore file
- Added rules to .gitignore file to ignore executables and intermediate compilation files (*.o, etc.)
- Removed binary files from repo
* Changed reference to PDDL lexer file from /src/Parser/lex.yy to src/Parser/lex.yy
* Added generated file src/pddl+.cpp
Are you sure we should ignore the makefile? |
Hi, It's been months, but probably not, one doesn't want to ignore the Makefile :) I can't remember why I put it there, really. Miquel |
Aside from the need of removing the Makefile from the .gitignore file, the rest of this PR would be quite useful, since as of now the fact of having all the object files downladed from the repo makes it necessary to issue a "make clean" before the build, otherwise on some architectures the linker finds trouble linking the mix of newly-created .o files with the old ones. This is BTW exactly what is reported in #11 |
+1 this PR solved my problems compiling. |
Dear VAL supporters. We've recently managed to re-merge a large fork (see #42) and in the process resolved many popular requests, did a major clean-up and made things ready for continuous integration, which will help us safely service future pull requests. We've also setup a build pipeline to democratize binaries for Linux, Windows and MacOS users. We understand that resolving merge conflicts in your forks may be difficult and will cause some short term pain, but we believe this is a good investment for the future of the project and hope to see your future contributions into this cleaned-up codebase! |