Merges #9, #13, #15, #24, fixes #21, #34 #25
Conversation
* Changed reference to PDDL lexer file from /src/Parser/lex.yy to src/Parser/lex.yy
* Added generated file src/pddl+.cpp
Now LINKER uses the value of CXX. At the same time, I introduced use of the standard LEX and YACC variables.
I spent a couple hours trying to figure out Mac executables. A 5-word entry should help others!
In my experience, this is too stringent. I find it breaks the build even on cosmetic errors like "misleading indentation." Inclined to think that this should change to be an option for active developers only, and left off for users.
…and also NIL=() precondition/effects
* Removed FlexLexer.h for the old version. Use the system-provided FlexLexer.h * Completely fixed up the compilation pipeline for pddl+.lex * Removed the duplicated parser code in src/Parser
guicho271828
changed the title
|
Dear VAL supporters. We've recently managed to re-merge a large fork (see #42) and in the process resolved many popular requests, did a major clean-up and made things ready for continuous integration, which will help us safely service future pull requests. We've also setup a build pipeline to democratize binaries for Linux, Windows and MacOS users. We understand that resolving merge conflicts in your forks may be difficult and will cause some short term pain, but we believe this is a good investment for the future of the project and hope to see your future contributions into this cleaned-up codebase! |
|
Switching to CMake to allow Windows build ... |
Fast Downward has required CMake since 2015 and has worked on Windows, Mac and Linux for ages. |
|
VAL is being used in a Windows environment in applications we are involved with, so this is a necessary configuration to support. Since we want to share the other consequences of the work we are doing, we want to make a single branch that is effective for all of the community and that means including Windows. Yes, the move to CMake is more complex, but the price is not too high, I think. However, if you would like to consider additional parallel support for make alone, then we might be able to add this to the branch for people who only want to compile on Linux (+ MacOS, maybe, although MacOS introduces more problems than Windows, we found!).
…________________________________
From: Masataro Asai <[email protected]>
Sent: 08 August 2019 14:17:33
To: KCL-Planning/VAL <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [KCL-Planning/VAL] Merges #9, #13, #15, #24, fixes #21, #34 (#25)
Switching to CMake to allow Windows build ...
Given its (personal opinion: unnecessary) complexity, I think it is a bit difficult to justify because eventually programs like VAL are combined with planners like Fast Downward, which requires Linux or Mac usually.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKCL-Planning%2FVAL%2Fpull%2F25%3Femail_source%3Dnotifications%26email_token%3DAB2KOVF6RI6277IMU4Z2L4LQDQMG3A5CNFSM4EN6JQQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33SMSA%23issuecomment-519513672&data=01%7C01%7Cderek.long%40kcl.ac.uk%7C49a17207c92f4dbb0a0b08d71c02c708%7C8370cf1416f34c16b83c724071654356%7C0&sdata=KfQLuR9MXVE7KBXJ1Vc0IFZlMesgNN1JBoYWoSBdFh4%3D&reserved=0>, or mute the thread<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB2KOVD2M5DUS5OI7KWDT23QDQMG3ANCNFSM4EN6JQQQ&data=01%7C01%7Cderek.long%40kcl.ac.uk%7C49a17207c92f4dbb0a0b08d71c02c708%7C8370cf1416f34c16b83c724071654356%7C0&sdata=JEH3fOw68aYeDbsV5kO%2BCRvW8iEm2nili0nlieRVWDc%3D&reserved=0>.
|
Merges #9, #13, #15, #24, fixes #21, address #22.
By merging this PR, all other pull-requests can be closed.