Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation issues causing compiler errors #24

Closed
wants to merge 1 commit into from

Conversation

morxa
Copy link

@morxa morxa commented Jan 10, 2018

This should fix #18.

I'm not sure if the indentation in Validator.cpp is correct. It seems like the condition if(planRepairValidator->checkGoal(theGoal)) was supposed to scope only over goalSatisfied = true;, but someone with a better understanding of the code should check if this is correct.

@jan-dolejsi
Copy link
Contributor

Dear VAL supporters. We've recently managed to re-merge a large fork (see #42) and in the process resolved many popular requests, did a major clean-up and made things ready for continuous integration, which will help us safely service future pull requests. We've also setup a build pipeline to democratize binaries for Linux, Windows and MacOS users.

We understand that resolving merge conflicts in your forks may be difficult and will cause some short term pain, but we believe this is a good investment for the future of the project and hope to see your future contributions into this cleaned-up codebase!

@morxa morxa closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAL fails to compile with recent gcc (6.3.0)
2 participants