chore(client) upgrade Go to 1.23 and macOS to 11 #2308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
requested changes
Dec 10, 2024
|
Ah, I’m having the same build issue I had before. I probably need to clean the build to reproduce this. |
|
I'll close this PR for now and upgrade Go later. #2307 already upgraded macOS to 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Go to 1.23 so we can use some of the modern APIs and leverage fixes and optimizations:
Go 1.23 requires macOS 11, which has reached end of life over a year ago:
https://endoflife.date/macos
We should probably drop support for platforms that reached end of life over a year ago, so if we are ok, I can upgrade to macOS 12.
I also upgraded some of the Go dependencies.