Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client/macos): update minimum deployment target to 12.0 #2307

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(client/macos): update minimum deployment target to 12.0 #2307

merged 2 commits into from
Dec 10, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Dec 9, 2024 •
edited
Loading

macOS 12 recently reached end of life. Anything older reached end of life at least 1 year ago: https://endoflife.date/macos

@sbruens sbruens requested a review from daniellacosse December 9, 2024 22:34
@sbruens sbruens requested a review from a team as a code owner December 9, 2024 22:34
fortuna
fortuna approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the Taskfile and the Swift Package as well

@fortuna
Copy link
Collaborator

fortuna commented Dec 10, 2024

See #2308

@fortuna
Copy link
Collaborator

fortuna commented Dec 10, 2024

And don't forget the iOS xcode project, as that is needed by Catalyst

@sbruens sbruens requested a review from a team as a code owner December 10, 2024 15:18
fortuna
fortuna approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

We may want to update iOS later too. I noticed it’s still behind 15..

@sbruens
Copy link
Contributor Author

sbruens commented Dec 10, 2024

We may want to update iOS later too. I noticed it’s still behind 15..

Yeah was going to look at that separately.

And don't forget the iOS xcode project, as that is needed by Catalyst

I believe having iOS/Catalyst set to 15.5 = macOS 12.4. I'm not sure that we can even set a different minimum Catalyst version in the iOS project itself.

@sbruens sbruens merged commit 9c8f10e into master Dec 10, 2024
22 checks passed
@sbruens sbruens deleted the sbruens/macos-min-version branch December 10, 2024 15:43
@fortuna fortuna mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

@daniellacosse daniellacosse daniellacosse approved these changes

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbruens @fortuna @daniellacosse @jyyi1