Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace all pngs with svgs now that we've moved to catalyst #1750

Merged
merged 4 commits into from
Oct 24, 2023
Merged

chore: replace all pngs with svgs now that we've moved to catalyst #1750

merged 4 commits into from
Oct 24, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 9, 2023 •
edited
Loading

This is a rollback of #1562.

7nt7na95WYrSiMv

@github-actions github-actions bot added the size/S label Oct 9, 2023
@sbruens sbruens requested a review from daniellacosse October 9, 2023 19:28
@sbruens sbruens marked this pull request as ready for review October 9, 2023 19:29
@sbruens sbruens requested a review from a team as a code owner October 9, 2023 19:29
daniellacosse
daniellacosse approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind posting a screenshot?

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/www/ui_components/about-view.js 100% <ø> (ø)
src/www/ui_components/app-root.js 4% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@sbruens
Copy link
Contributor Author

sbruens commented Oct 9, 2023

Mind posting a screenshot?

Edited the top comment to add a screenshot.

@sbruens sbruens closed this Oct 9, 2023
@sbruens sbruens reopened this Oct 9, 2023
@sbruens
Copy link
Contributor Author

sbruens commented Oct 10, 2023

Mind posting a screenshot?

Done.

@sbruens sbruens merged commit 0e3e38b into master Oct 24, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/svgs branch October 25, 2023 14:31
sbruens added a commit that referenced this pull request Nov 9, 2023
@sbruens
Revert "chore: replace all pngs with svgs now that we've moved to cat…
acc2c2e 
…alyst (#1750)"

This reverts commit 0e3e38b.
@sbruens sbruens mentioned this pull request Nov 9, 2023
Merged
sbruens added a commit that referenced this pull request Nov 10, 2023
@sbruens
chore: replace all svgs with pngs (#1779)
f38b935 
* Revert "chore: replace all pngs with svgs now that we've moved to catalyst (#1750)"

This reverts commit 0e3e38b.

* Install latest `node-gyp` version that fixes issue on Python 3.12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbruens @daniellacosse