Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace all svgs with pngs #1779

Merged
merged 2 commits into from
Nov 10, 2023
Merged

chore: replace all svgs with pngs #1779

merged 2 commits into from
Nov 10, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Nov 9, 2023

Reverts #1750 to unblock old macos client release.

@sbruens sbruens requested a review from a team as a code owner November 9, 2023 18:59
@sbruens sbruens requested a review from daniellacosse November 9, 2023 18:59
@github-actions github-actions bot added the size/S label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/www/ui_components/about-view.js 100% <ø> (ø)
src/www/ui_components/app-root.js 4% <ø> (ø)

📢 Thoughts on this report? Let us know!

@fortuna
Copy link
Collaborator

fortuna commented Nov 9, 2023 via email

@sbruens sbruens changed the title Revert "chore: replace all pngs with svgs now that we've moved to catalyst" chore: replace all svgs with pngs Nov 9, 2023
@daniellacosse
Copy link
Contributor

@fortuna

Screenshot 2023-11-09 at 3 53 16 PM Reconfirmed the SVGs don't render when run with `SENTRY_DSN=https://www.test.dsn npm run action cordova/setup macos -- --buildMode=release --versionName=1.0.0`

@sbruens sbruens merged commit f38b935 into master Nov 10, 2023
14 checks passed
@sbruens sbruens deleted the revert-1750-sbruens/svgs branch November 10, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants