Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in Drupal 10.2 #990

Closed
wants to merge 2 commits into from
Closed

Fix tests in Drupal 10.2 #990

wants to merge 2 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Nov 2, 2023

GitHub Issue: #989

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Alters the submit button name to hopefully make tests pass in Drupal 10.2 including dev versions.

What's new?

So far: changed the value of the submit button.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

If tests pass on 10.2 and below, this is a success.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@rosiel rosiel changed the base branch from master to 2.x November 2, 2023 13:58
@rosiel rosiel closed this Nov 2, 2023
@rosiel rosiel reopened this Nov 2, 2023
@rosiel rosiel closed this Nov 2, 2023
@rosiel
Copy link
Member Author

rosiel commented Nov 2, 2023

Tests aren't running, which defeats the one purpose of opening this PR. Will close and try again.

@rosiel rosiel mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant