Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #991

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Fix tests #991

merged 9 commits into from
Nov 8, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Nov 2, 2023

GitHub Issue: #989

Re-do of #990 because tests didn't run

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Changes the name of the submit button in our tests.

What's new?

Not much just the name of the button to submit in the add-field page (so far)

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@rosiel
Copy link
Member Author

rosiel commented Nov 2, 2023

I'm pretty sure tests will fail; as I just tested it seems 10.2.x-dev is lower than 10.2.0-dev. I'll wait for failure then change the less-than test to 10.2.x-dev (unless there are better suggestions)

@rosiel
Copy link
Member Author

rosiel commented Nov 2, 2023

There are many PHP deprecation errors in php 8.2 on Drupal 10.2.
These are related to an issue in Features: https://www.drupal.org/project/features/issues/3375425 (It seems very active and it's RTBC so it should be merged soon. Anyway it seems tangential to this PR.)

@joecorall joecorall mentioned this pull request Nov 3, 2023
* lint

* Update JsonldTypeAlterReactionTest.php
@rosiel rosiel assigned rosiel and unassigned rosiel Nov 8, 2023
@seth-shaw-asu seth-shaw-asu merged commit 4b2b9b2 into 2.x Nov 8, 2023
18 checks passed
@rosiel rosiel deleted the fix-tests branch November 16, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants