Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parent directory exists #1062

Draft
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Draft

Ensure parent directory exists #1062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Flysystem/Adapter/FedoraAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@ public function write($path, $contents, Config $config) {
}
}

$parts = explode('/', $path);
array_pop($parts);
if ($parts) {
$this->createDir(implode('/', $parts), $config);
}
Comment on lines +301 to +305
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of exploding/imploding, this should probably use an implementation of FileSystemInterface::dirname(), such as FileSystem::dirname(). PHP's dirname() might work; however, FileSystemInterface::dirname() indicates:

PHP's dirname() does not properly pass streams, so this function fills that gap. It is backwards compatible with normal paths and will use PHP's dirname() as a fallback.

Compatibility: normal paths and stream wrappers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes that makes more sense, silly to reinvent.

I plan to verify whether this is a real issue (seems like something that would have been discovered before now?) and come back with some repro steps to confirm.


$response = $this->fedora->saveResource(
$path,
$contents,
Expand Down