Ensure parent directory exists #1062
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-vessey
reviewed
Oct 17, 2024
Comment on lines
+301
to
+305
| $parts = explode('/', $path); | ||
| array_pop($parts); | ||
| if ($parts) { | ||
| $this->createDir(implode('/', $parts), $config); | ||
| } |
There was a problem hiding this comment.
Instead of exploding/imploding, this should probably use an implementation of FileSystemInterface::dirname(), such as FileSystem::dirname(). PHP's dirname() might work; however, FileSystemInterface::dirname() indicates:
PHP's dirname() does not properly pass streams, so this function fills that gap. It is backwards compatible with normal paths and will use PHP's dirname() as a fallback.
Compatibility: normal paths and stream wrappers.
There was a problem hiding this comment.
Thanks, yes that makes more sense, silly to reinvent.
I plan to verify whether this is a real issue (seems like something that would have been discovered before now?) and come back with some repro steps to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #1061
What does this Pull Request do?
Create the containing directory if there is one.
What's new?
How should this be tested?
See #1061
Documentation Status
n/a?
Interested parties
@Islandora/committers