Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add certificates to CLI interface in compatible transaction-sign #972

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Add certificates to CLI interface in compatible transaction-sign #972

wants to merge 19 commits into from
+1,273 −258

Commits on Nov 20, 2024

  1. Use new inject function instead of the XToY era functions

    @smelc @carbolymer
    smelc authored and carbolymer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a272b0b View commit details
    Browse the repository at this point in the history

  2. Remove use of experimental api in transaction balancing

    @carbolymer
    carbolymer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ea0476c View commit details
    Browse the repository at this point in the history

  3. Bump cardano-api-10.3

    @carbolymer
    carbolymer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3e9a647 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Add Cardano.CLI.Plutus.Minting module 

    Define the data definition CliMintScriptRequirements
This type makes it clearer that we require the policy id for transaction
construction when using a minting script
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3a164af View commit details
    Browse the repository at this point in the history

  2. Refine plutusP to return AnyPlutusScriptVersion instead of 

    AnyScriptLanguage
Replace ScriptWitnessFiles WitCtxMint with CliMintScriptRequirements
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8426cdb View commit details
    Browse the repository at this point in the history

  3. Modify PlutusReferenceScriptWitnessFiles to accept 

    AnyPlutusScriptVersion instead of AnyScriptLanguage
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d4d3753 View commit details
    Browse the repository at this point in the history

  4. Implement readFileSimpleScript and readFilePlutusScript 

    Refactor readScriptWitness and eliminate invalid states

Factor out fromSomeTypeSimpleScript and fromSomeTypePlutusScripts

fromSomeTypePlutusScripts should automatically be updated as soon as the
Enum AnyPlutusScriptVersion instance is updated in cardano-api
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b2ac548 View commit details
    Browse the repository at this point in the history

  5. Replace ScriptWitnessFiles WitCtxMint with CliMintScriptRequirements

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5c276ae View commit details
    Browse the repository at this point in the history

  6. Propagate MintScriptWitWithPolId era

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d7a6085 View commit details
    Browse the repository at this point in the history

  7. Remove gatherMintingWitnesses because by default we require a PolicyId

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e567a54 View commit details
    Browse the repository at this point in the history

  8. Add TxCmdCliScriptWitnessError to TxCmdError 

    Add ScriptDecodeUnknownPlutusScriptVersion to ScriptDecodeError
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    34281ab View commit details
    Browse the repository at this point in the history

  9. Review rename and refactor suggestions

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8453b12 View commit details
    Browse the repository at this point in the history

  10. Module split and rename suggestions

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fafcea1 View commit details
    Browse the repository at this point in the history

  11. Add separate error modules: 

    - Cardano.CLI.Types.Errors.PlutusScriptDecodeError
- Cardano.CLI.Types.Errors.ScriptDataError
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6c4869f View commit details
    Browse the repository at this point in the history

  12. With the implementation and use MintScriptWitnessWithPolicyId era to 

    handle all minting scripts (simple and plutus) we no longer have to
accomodate for the PolicyId in the constructors
PlutusReferenceScriptWitnessFiles and SimpleReferenceScriptWitnessFiles

This is evidenced by the diff of this commit

The goal is to deprecate ScriptWitnessFiles and replace it with a
collection of types for the different script purposes. The first example
of this is MintScriptWitnessWithPolicyId era
    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e72b227 View commit details
    Browse the repository at this point in the history

  13. Update createTxMintValue and propagate the removal of Maybe PolicyId 

    from PReferenceScript and SReferenceScript constructors

Co-authored-by: Mateusz Gałażyn <[email protected]>
    @Jimbo4350 @carbolymer
    Jimbo4350 and carbolymer committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1e136a3 View commit details
    Browse the repository at this point in the history

  14. Formatting fixes

    @Jimbo4350
    Jimbo4350 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5649c78 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Add certs to compatible transaction build command

    @carbolymer
    carbolymer committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7965ce2 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Added reference test for `compatible conway transaction singed-transa… 

    …ction`
    @carbolymer
    carbolymer committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bd0fc1e View commit details
    Browse the repository at this point in the history