Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add certificates to CLI interface in compatible transaction-sign #972

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Add certificates to CLI interface in compatible transaction-sign #972

wants to merge 19 commits into from
+1,273 −258

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Add certificates to CLI interface in `compatible transaction-sign` 
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

na

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 128b63e to 970a956 Compare November 21, 2024 12:38
@Jimbo4350
Add Cardano.CLI.Plutus.Minting module
3a164af 
Define the data definition CliMintScriptRequirements
This type makes it clearer that we require the policy id for transaction
construction when using a minting script
@Jimbo4350
Refine plutusP to return AnyPlutusScriptVersion instead of
8426cdb 
AnyScriptLanguage
Replace ScriptWitnessFiles WitCtxMint with CliMintScriptRequirements
@Jimbo4350
Modify PlutusReferenceScriptWitnessFiles to accept
d4d3753 
AnyPlutusScriptVersion instead of AnyScriptLanguage
@Jimbo4350
Implement readFileSimpleScript and readFilePlutusScript
b2ac548 
Refactor readScriptWitness and eliminate invalid states

Factor out fromSomeTypeSimpleScript and fromSomeTypePlutusScripts

fromSomeTypePlutusScripts should automatically be updated as soon as the
Enum AnyPlutusScriptVersion instance is updated in cardano-api
@Jimbo4350
Replace ScriptWitnessFiles WitCtxMint with CliMintScriptRequirements
5c276ae
@Jimbo4350
Propagate MintScriptWitWithPolId era
d7a6085
@Jimbo4350
Remove gatherMintingWitnesses because by default we require a PolicyId
e567a54
@Jimbo4350
Add TxCmdCliScriptWitnessError to TxCmdError
34281ab 
Add ScriptDecodeUnknownPlutusScriptVersion to ScriptDecodeError
@Jimbo4350
Review rename and refactor suggestions
8453b12
@Jimbo4350
Module split and rename suggestions
fafcea1
@Jimbo4350
Add separate error modules:
6c4869f 
- Cardano.CLI.Types.Errors.PlutusScriptDecodeError
- Cardano.CLI.Types.Errors.ScriptDataError
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 970a956 to 1ef3e12 Compare November 21, 2024 18:55
Jimbo4350 and others added 3 commits November 21, 2024 15:07
@Jimbo4350
With the implementation and use MintScriptWitnessWithPolicyId era to
e72b227 
handle all minting scripts (simple and plutus) we no longer have to
accomodate for the PolicyId in the constructors
PlutusReferenceScriptWitnessFiles and SimpleReferenceScriptWitnessFiles

This is evidenced by the diff of this commit

The goal is to deprecate ScriptWitnessFiles and replace it with a
collection of types for the different script purposes. The first example
of this is MintScriptWitnessWithPolicyId era
@Jimbo4350 @carbolymer
Update createTxMintValue and propagate the removal of Maybe PolicyId
1e136a3 
from PReferenceScript and SReferenceScript constructors

Co-authored-by: Mateusz Gałażyn <[email protected]>
@Jimbo4350
Formatting fixes
5649c78
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 1ef3e12 to a2cd934 Compare November 22, 2024 21:47
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from a2cd934 to 7965ce2 Compare November 22, 2024 21:58
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 1a8e2af to bd0fc1e Compare November 25, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 will be requested when the pull request is marked ready for review Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc will be requested when the pull request is marked ready for review smelc is a code owner

@palas palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carbolymer @smelc @Jimbo4350