chore: change info to debug logging #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomvbe
requested review from
Yalz,
rorlic,
pj-cegeka and
jobulcke
as code owners
jobulcke
approved these changes
Nov 22, 2023
| var httpMethod = HttpMethod.POST.name(); | ||
| var type = request.headers().contentType().map(MediaType::toString).orElse("(unknown)"); | ||
| long contentLength = request.headers().contentLength().orElse(0L); | ||
| log.atDebug().log("%s /%s type: %s length: %s".formatted(httpMethod, endpoint, type, contentLength)); |
There was a problem hiding this comment.
Is there a reason why you would not use the built in formatting from the debugger in stead of the String.formatted()?
There was a problem hiding this comment.
Nope, good remark. I started refactoring from from a String.formatted and didn't question it. I will change it.
...ctors/ldio-kafka/src/main/java/be/vlaanderen/informatievlaanderen/ldes/ldio/LdioKafkaIn.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
jobulcke
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.