Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug logging instead of info logging for http request logging #404

Closed
Tomvbe opened this issue Nov 20, 2023 · 0 comments · Fixed by #410
Closed

Use debug logging instead of info logging for http request logging #404

Tomvbe opened this issue Nov 20, 2023 · 0 comments · Fixed by #410
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers needs triage Issue needs to be evaluated by team

Comments

@Tomvbe
Copy link
Contributor

Tomvbe commented Nov 20, 2023

Currently we have some logging on incoming and outgoing http messages. For example in LdioHttpIn:

LOGGER.info("POST " + "/%s".formatted(endpoint) + " type:" + type + " length:" + req.headers().contentLength().orElse(0L));
  1. This should be debug logging instead of info logging.
  2. We should also have this logging on the kafka components.
  3. The formatting of these log message can be improved as well. Use one format string and provide all the params.
@Tomvbe Tomvbe added enhancement New feature or request good first issue Good for newcomers needs triage Issue needs to be evaluated by team labels Nov 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in VSDS Backlog Nov 20, 2023
@Tomvbe Tomvbe self-assigned this Nov 22, 2023
@Tomvbe Tomvbe moved this from 📋 Backlog to 👀 In review in VSDS Backlog Nov 22, 2023
@Tomvbe Tomvbe linked a pull request Nov 22, 2023 that will close this issue
@Tomvbe Tomvbe closed this as completed Nov 22, 2023
@Yalz Yalz moved this from 👀 In review to ✅ Done in VSDS Backlog Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers needs triage Issue needs to be evaluated by team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant