Introduce plugin table #108

sukhwinder33445 · 2023-10-09T13:10:53Z

resolves #107

change upgrade schema name -- no change needed

cmd/icinga-notifications-daemon/main.go

internal/channel/plugin.go

cmd/icinga-notifications-daemon/main.go

internal/channel/channel.go

internal/incident/incident.go

internal/channel/channel.go

julianbrost

(So far, just the first round of findings, there'll probably be more comments in the future.)

schema/pgsql/upgrades/plugin_table.sql

cmd/channel/email/main.go

internal/channel/channel.go

internal/channel/plugin.go

yhabteab

I know I'm not even good at this either, but please document at least the exported methods.

cmd/channel/email/main.go

cmd/icinga-notifications-daemon/main.go

internal/channel/plugin.go

internal/channel/channel.go

internal/incident/incident.go

pkg/plugin/plugin.go

schema/pgsql/schema.sql

julianbrost · 2023-11-09T16:01:07Z

cmd/channel/email/main.go

+	minValue := types.Int{NullInt64: sql.NullInt64{Int64: 0}}
+	minValue.Valid = true
+
+	maxValue := types.Int{NullInt64: sql.NullInt64{Int64: 65535}}
+	maxValue.Valid = true


You can just set Valid as well within the struct initializer (and then also move it into the initialization below so you don't need the extra variables).

Note: types.Int is buggy and ignores the omitempty flag.

Not sure if that's a bug of types.Int or just a limitation of encoding/json. Anyways, looks like it just writes null to the JSON then. Would that be a problem for the web module?

No, Web can handle it.

pkg/plugin/plugin.go

internal/channel/channel.go

internal/channel/plugin.go

- Introduce a plugin table to store plugin related info. On daemon start the plugin table is upserted. - Each plugin defines its own required form elements for config as configOption(s). - Configured channels start and maintain there plugin.

…ed chars

…plugin termination

This is a missing change from #100

…ed/stopped plugin

pkg/plugin/plugin.go

- The Upsert() func is no longer required because Info{} contains all that properties. - Fix reciver param name of Info.TableName() method. - Remove type from GetInfo to make it non-configurable. The file name should always be used as the type.

Old review

only-new-issues seems to hide some issues even if they are introduced by a PR, i.e. leaving a struct field there but removing all usages of it. This can result in CI failures after merging, see #108 and 6f4b437 for example.

only-new-issues seems to hide some issues in PRs even if they are introduced there. For example, removing all usages of a struct field without touching the field itself is not detected. This can result in CI failures after merging, see #108 and 6f4b437 for example.

## Requires: - Icinga/icinga-notifications#108 - Icinga/icinga-notifications#142

sukhwinder33445 self-assigned this Oct 9, 2023

cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 9, 2023

sukhwinder33445 changed the base branch from main to enhance-channel October 9, 2023 13:11

sukhwinder33445 force-pushed the introduce-plugin-table branch 2 times, most recently from af87177 to 7bac817 Compare October 10, 2023 08:52

sukhwinder33445 force-pushed the enhance-channel branch 2 times, most recently from aab13a9 to 806702e Compare October 10, 2023 10:11

sukhwinder33445 force-pushed the introduce-plugin-table branch 5 times, most recently from e8a319d to 8db1d1b Compare October 12, 2023 11:22

Base automatically changed from enhance-channel to main October 16, 2023 11:30

sukhwinder33445 force-pushed the introduce-plugin-table branch 2 times, most recently from c1ee4fd to 46cb339 Compare October 16, 2023 13:30

sukhwinder33445 requested a review from julianbrost October 16, 2023 14:40

sukhwinder33445 force-pushed the introduce-plugin-table branch from 46cb339 to 8b39eaf Compare October 18, 2023 08:36

julianbrost requested changes Oct 18, 2023

View reviewed changes

sukhwinder33445 force-pushed the introduce-plugin-table branch 3 times, most recently from 4e50f91 to 770caaa Compare October 19, 2023 10:38

sukhwinder33445 requested a review from julianbrost October 19, 2023 10:40

sukhwinder33445 force-pushed the introduce-plugin-table branch from 770caaa to cf4bed8 Compare October 19, 2023 11:27

julianbrost requested changes Oct 19, 2023

View reviewed changes

sukhwinder33445 force-pushed the introduce-plugin-table branch from cf4bed8 to 0260388 Compare October 24, 2023 07:41

sukhwinder33445 requested a review from julianbrost October 24, 2023 07:42

sukhwinder33445 force-pushed the introduce-plugin-table branch 3 times, most recently from c7474ff to ac79bb8 Compare October 25, 2023 09:59

yhabteab previously requested changes Oct 25, 2023

View reviewed changes

julianbrost requested changes Nov 9, 2023

View reviewed changes

sukhwinder33445 added 12 commits November 10, 2023 11:25

Enhance channel plugins

b9a8b8d

- Introduce a plugin table to store plugin related info. On daemon start the plugin table is upserted. - Each plugin defines its own required form elements for config as configOption(s). - Configured channels start and maintain there plugin.

Improve channel plugin log messages

4d337a6

email: Remove not in use plugin config_attr options

1dd36ca

plugin: Add method ValidateType to check if the type contains allow…

cb501d2

…ed chars

channel/plugin.go: Remove unnecessary Mutex and add stopOnce for …

c257766

…plugin termination

channel/channel.go: Improve Notify() functionality

518eb9c

channel/channel.go: Use context.context to stop the channel

fbaf6b6

config/channel.go: Fix: Channel id cannot change, but type can

0418407

This is a missing change from #100

channel/channel.go: Fix race-condition on c.Config and c.Type

5c45f56

channel/plugin.go: Add pid to plugin logger to differ between start…

f57e777

…ed/stopped plugin

Improve logs

322748c

channel/channel.go: Create incident url correctly

2727ee1

sukhwinder33445 force-pushed the introduce-plugin-table branch from a5af8d9 to 346aa21 Compare November 10, 2023 10:31

julianbrost requested changes Nov 13, 2023

View reviewed changes

pkg/plugin/plugin.go Outdated Show resolved Hide resolved

pkg/plugin/plugin.go Outdated Show resolved Hide resolved

sukhwinder33445 force-pushed the introduce-plugin-table branch from 346aa21 to 26376b9 Compare November 13, 2023 11:41

sukhwinder33445 force-pushed the introduce-plugin-table branch from 26376b9 to 7d9227e Compare November 13, 2023 14:03

sukhwinder33445 requested a review from julianbrost November 13, 2023 14:04

julianbrost approved these changes Nov 14, 2023

View reviewed changes

julianbrost merged commit 6f4b437 into main Nov 14, 2023
2 checks passed

julianbrost deleted the introduce-plugin-table branch November 14, 2023 12:21

julianbrost mentioned this pull request Nov 14, 2023

golangci-lint: disable only-new-issues #125

Merged

julianbrost mentioned this pull request Nov 15, 2023

Add encryption and pass auth to email channel #123

Merged

nilmerg added a commit to Icinga/icinga-notifications-web that referenced this pull request Dec 19, 2023

Use available_channel_type table data to create channelForm (#143)

8506590

## Requires: - Icinga/icinga-notifications#108 - Icinga/icinga-notifications#142

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce plugin table #108

Introduce plugin table #108

sukhwinder33445 commented Oct 9, 2023 •

edited by julianbrost

Loading

julianbrost left a comment

yhabteab left a comment

julianbrost Nov 9, 2023

sukhwinder33445 Nov 10, 2023

julianbrost Nov 13, 2023

sukhwinder33445 Nov 13, 2023

Introduce plugin table #108

Introduce plugin table #108

Conversation

sukhwinder33445 commented Oct 9, 2023 • edited by julianbrost Loading

julianbrost left a comment

Choose a reason for hiding this comment

yhabteab left a comment

Choose a reason for hiding this comment

julianbrost Nov 9, 2023

Choose a reason for hiding this comment

sukhwinder33445 Nov 10, 2023

Choose a reason for hiding this comment

julianbrost Nov 13, 2023

Choose a reason for hiding this comment

sukhwinder33445 Nov 13, 2023

Choose a reason for hiding this comment

sukhwinder33445 commented Oct 9, 2023 •

edited by julianbrost

Loading