golangci-lint: disable only-new-issues #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
force-pushed
the
golangci-lint-all-issues
branch
from
8eccd53 to
d427f02
Compare
julianbrost
force-pushed
the
golangci-lint-all-issues
branch
from
d427f02 to
56d59ba
Compare
oxzi
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only-new-issuesseems to hide some issues in PRs even if they are introduced there. For example, removing all usages of a struct field without touching the field itself is not detected. This can result in CI failures after merging, see #108 and 6f4b437 for example.