[ESSI-1288] In AllinsonFlex, ensure empty properties return a Hash #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raised AllinsonFlex issue here: |
|
Closing as we can just avoid this, and it can be fixed directly in AllinsonFlex later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a work class was configured to use AllinsonFlex with no properties configured, the resultant
DynamicSchemaobject had anilvalue, instead of an empty Hash, in thepropertiesfield of theschemaattribute (serialized JSON). Granted, this is an odd situation you probably wouldn't want to create -- but other parts of the stack assume a valid Hash value is present there, and break. This includes the issue prompting the ESSI-1288 story, the form to create new work not rendering. This monkeypatches that issue.We may not actually want to merge this PR, as we can also simply avoid the situation until such time as it is fixed in AllinsonFlex.