Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring no properties results in a breaking 'nil' value, instead of an empty hash, for DynamicSchema.schema['properties'] #56

Open
aploshay opened this issue Apr 16, 2021 · 0 comments

Comments

@aploshay
Copy link
Contributor

When a work class was configured to use AllinsonFlex with no properties configured, the resultant DynamicSchema object had a nil value, instead of an empty Hash, in the properties field of the schema attribute (serialized JSON). Granted, this is an odd situation you probably wouldn't want to create -- but other parts of the stack assume a valid Hash value is present there, and break. This includes the form to create new work not rendering.

You'll want a more elegant solution within allinson_flex, but there's a monkeypatch PR up for a project using allinson_flex, here:
IU-Libraries-Joint-Development/essi#292

@aploshay aploshay changed the title Configuring no properties results in a breaking 'nil' values instead of an empty hash for DynamicSchema.schema['properties']properties'] Configuring no properties results in a breaking 'nil' value, instead of an empty hash, for DynamicSchema.schema['properties'] Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant