Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

168 - Files table UI [1/2] - Integration files count #173

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Sep 7, 2023

What this PR does / why we need it:

This PR adds the integration of the js-dataverse use cases to get the files count info.

Which issue(s) this PR closes:

Special notes for your reviewer:

Changes

  1. Integration of js-dataverse getDatasetFileCounts
  2. Some bug fixes on the react components

Notes

During the integration we realised that the getDatasetFileCounts needs an additional argument to take into account the filtered files. So we'll address that in this new issue

Also, the e2e tests are failing in the Github Action because the dataverse branch haven't been merged yet. But they should work locally npm run test:e2e

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh 9834-files-api-extension-file-counts
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes for the getDatasetFileCounts

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. Upload some files
  5. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  6. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  7. You are seeing now the same Dataset in the SPA, check that the number of files is correct and the pagination is working correctly. Also the filters should work but they'll show a wrong number of coincidences for the filters since getDatasetFileCounts is not taking into account the applied filters.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray changed the title Feature/168 integration file counts 168 - Files table UI [1/2] - Integration files count Sep 7, 2023
@MellyGray MellyGray marked this pull request as ready for review September 7, 2023 10:58
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 7, 2023
@coveralls
Copy link

Coverage Status

coverage: 98.58% (+0.5%) from 98.104% when pulling 3453075 on feature/168-integration-file-counts into ec98c1f on feature/167-integration-dataset-page-filters.

@MellyGray
Copy link
Contributor Author

Merging this into feature/167-integration-dataset-page-filters because filters won't work without files count integration

@MellyGray MellyGray merged commit 0cc585e into feature/167-integration-dataset-page-filters Sep 22, 2023
4 of 6 checks passed
@MellyGray MellyGray deleted the feature/168-integration-file-counts branch September 22, 2023 10:47
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…unts

Merging this into feature/167-integration-dataset-page-filters because filters won't work without files count integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants