-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
168 - Files table UI [1/2] - Integration files count #173
Merged
MellyGray
merged 9 commits into
feature/167-integration-dataset-page-filters
from
feature/168-integration-file-counts
Sep 22, 2023
Merged
168 - Files table UI [1/2] - Integration files count #173
MellyGray
merged 9 commits into
feature/167-integration-dataset-page-filters
from
feature/168-integration-file-counts
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
changed the title
Feature/168 integration file counts
168 - Files table UI [1/2] - Integration files count
Sep 7, 2023
…//github.com/IQSS/dataverse-frontend into feature/168-integration-file-counts
Merging this into feature/167-integration-dataset-page-filters because filters won't work without files count integration |
MellyGray
merged commit Sep 22, 2023
0cc585e
into
feature/167-integration-dataset-page-filters
4 of 6 checks passed
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…unts Merging this into feature/167-integration-dataset-page-filters because filters won't work without files count integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the integration of the js-dataverse use cases to get the files count info.
Which issue(s) this PR closes:
Special notes for your reviewer:
Changes
Notes
During the integration we realised that the getDatasetFileCounts needs an additional argument to take into account the filtered files. So we'll address that in this new issue
Also, the e2e tests are failing in the Github Action because the dataverse branch haven't been merged yet. But they should work locally npm run test:e2e
Suggestions on how to test this:
Step 1: Run the development environment
npm I
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh 9834-files-api-extension-file-counts
Step 2: Test Dataset View mode with the implemented changes for the getDatasetFileCounts
?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: