-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filters to getDatasetFiles use case #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 nothing to add, let's move it forward!
@GPortas Do you know where currently this is used in UI. In addition to automated tests, just wanted to try it out in pre SPA ui. |
Hi @kcondon ! You can try it out in this branch PR IQSS/dataverse-frontend#173 |
Sorry, first day back testing SPA and have temporarily forgotten some basic steps, like checking which repo the pr is for. :) |
What this PR does / why we need it:
Adds a new FileCriteria parameter to the getDatasetFiles use case, which applies different optional filters to the final API call.
Also includes a small refactor described in #80 (comment)
Adds latestRestricted property to File model (dataFile level).
Which issue(s) this PR closes:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Adds filters to getDatasetFiles use case