Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dxm preprocessing scripts #2

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Improve Dxm preprocessing scripts #2

merged 7 commits into from
Jun 11, 2024

Conversation

leavauchier
Copy link
Contributor

@leavauchier leavauchier commented May 30, 2024 •
edited
Loading

  • Make macro a python module so that it can be installed and imported from anywhere in the docker image
  • Add tests inside the docker image
  • Modify example scripts to be able to return:
    • a las file ony
    • with only the useful output dimensions added todo in another MR
  • Add test for the main python script

@leavauchier leavauchier marked this pull request as ready for review May 30, 2024 14:39
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch 2 times, most recently from 52a69de to a1a8cff Compare May 30, 2024 14:45
@leavauchier leavauchier marked this pull request as draft May 30, 2024 14:51
@leavauchier leavauchier marked this pull request as ready for review June 3, 2024 11:54
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from 220a5be to 0337519 Compare June 3, 2024 12:50
@leavauchier leavauchier marked this pull request as draft June 4, 2024 07:15
@leavauchier leavauchier marked this pull request as ready for review June 4, 2024 07:18
@leavauchier leavauchier marked this pull request as draft June 4, 2024 07:28
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from 0337519 to 5517584 Compare June 4, 2024 08:54
@leavauchier leavauchier changed the title Imrpove Dxm preprocessing scripts Improve Dxm preprocessing scripts Jun 4, 2024
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from 5517584 to 46dbce0 Compare June 6, 2024 10:10
@leavauchier leavauchier marked this pull request as ready for review June 6, 2024 11:45
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from 46dbce0 to b9bc166 Compare June 6, 2024 12:21
@leavauchier leavauchier requested a review from alavenant June 6, 2024 12:22
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch 2 times, most recently from a5ef9cd to b9bed7f Compare June 11, 2024 09:02
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from b9bed7f to b6a234b Compare June 11, 2024 09:36
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from f042a50 to 157d6dc Compare June 11, 2024 09:41
@leavauchier leavauchier force-pushed the dxm_preprocessing_script branch from 157d6dc to c567012 Compare June 11, 2024 09:43
@leavauchier leavauchier merged commit e3d21dc into main Jun 11, 2024
2 checks passed
@leavauchier leavauchier deleted the dxm_preprocessing_script branch June 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alavenant alavenant alavenant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leavauchier @alavenant