Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OptimizerResult.optimizer in Optimizer.minimize #1525

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 27, 2024

Fixes #1524.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (6eb4245) to head (31654ae).

Files with missing lines Patch % Lines
pypesto/optimize/optimizer.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1525      +/-   ##
===========================================
- Coverage    82.83%   82.80%   -0.04%     
===========================================
  Files          163      163              
  Lines        13962    13960       -2     
===========================================
- Hits         11565    11559       -6     
- Misses        2397     2401       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review November 27, 2024 10:32
@dweindl dweindl enabled auto-merge November 27, 2024 10:40
@dweindl dweindl self-assigned this Nov 27, 2024
@dweindl dweindl added this pull request to the merge queue Nov 28, 2024
Merged via the queue into ICB-DCM:develop with commit d1c9e52 Nov 28, 2024
18 checks passed
@dweindl dweindl deleted the fix_1525_result_optimizer branch November 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants