Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handled the presence and proxy case #120

Merged
merged 13 commits into from
Nov 20, 2023
Merged

handled the presence and proxy case #120

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
333e304
Update ServiceUtil.java
vishalhcl-5960 Oct 17, 2023
b662a41
Update ServiceUtil.java
vishalhcl-5960 Oct 19, 2023
f2be434
Merge branch 'HCL-TECH-SOFTWARE:master' into ASA-2762
vishalhcl-5960 Oct 25, 2023
7da9c72
Update ServiceUtil.java
vishalhcl-5960 Nov 7, 2023
1ffa948
ASA-2762
vishalhcl-5960 Nov 8, 2023
6b698c1
Merge branch 'HCL-TECH-SOFTWARE:ASA-2762' into ASA-2762
vishalhcl-5960 Nov 8, 2023
29e3bbd
Update DASTScan.java
vishalhcl-5960 Nov 8, 2023
ed2d60a
handled the presence case
vishalhcl-5960 Nov 15, 2023
637c729
Update DASTConstants.java
vishalhcl-5960 Nov 15, 2023
b7ec663
indentation issue
vishalhcl-5960 Nov 15, 2023
cdb8448
Merge branch 'ASA-2762' into ASA-2762
vishalhcl-5960 Nov 15, 2023
4512b12
Update DASTScan.java
vishalhcl-5960 Nov 15, 2023
09e7085
Update DASTScan.java
vishalhcl-5960 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/hcl/appscan/sdk/scanners/dynamic/DASTConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public interface DASTConstants {
String DYNAMIC_ANALYZER_WITH_FILE = "DynamicAnalyzerWithFile"; //$NON-NLS-1$
String SCAN_FILE = "ScanFile"; //$NON-NLS-1$
String SCAN_FILE_ID = "ScanFileId"; //$NON-NLS-1$
String PRESENCE_ID = "PresenceId"; //$NON-NLS-1$
String STARTING_URL = "StartingUrl"; //$NON-NLS-1$
String TRAFFIC_FILE = "trafficFile";
String TRAFFIC_FILE_ID = "LoginSequenceFileId";
Expand Down
8 changes: 5 additions & 3 deletions src/main/java/com/hcl/appscan/sdk/scanners/dynamic/DASTScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

import com.hcl.appscan.sdk.CoreConstants;
import com.hcl.appscan.sdk.Messages;
import com.hcl.appscan.sdk.auth.IAuthenticationProvider;
import com.hcl.appscan.sdk.error.InvalidTargetException;
import com.hcl.appscan.sdk.error.ScannerException;
import com.hcl.appscan.sdk.logging.DefaultProgress;
Expand Down Expand Up @@ -44,9 +45,10 @@ public void run() throws ScannerException, InvalidTargetException {
Map<String, String> params = getProperties();
params.put(STARTING_URL, target);

if(!ServiceUtil.isValidUrl(params.get(STARTING_URL),getServiceProvider().getAuthenticationProvider())) {
throw new ScannerException(Messages.getMessage(CoreConstants.ERROR_URL_VALIDATION));
}
IAuthenticationProvider authProvider = getServiceProvider().getAuthenticationProvider();
if(params.get(PRESENCE_ID).equals("") && !ServiceUtil.isValidUrl(params.get(STARTING_URL), authProvider, authProvider.getProxy())) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant you use "EMPTY"?

throw new ScannerException(Messages.getMessage(CoreConstants.ERROR_URL_VALIDATION));
}

String scanLoginType = null;
if (params.get(LOGIN_TYPE) != null) {
Expand Down
Loading