Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handled the presence and proxy case #120

Merged
merged 13 commits into from
Nov 20, 2023

Conversation

vishalhcl-5960
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023

CLA assistant check
All committers have signed the CLA.

throw new ScannerException(Messages.getMessage(CoreConstants.ERROR_URL_VALIDATION));
}
IAuthenticationProvider authProvider = getServiceProvider().getAuthenticationProvider();
if(params.get(PRESENCE_ID).equals("") && !ServiceUtil.isValidUrl(params.get(STARTING_URL), authProvider, authProvider.getProxy())) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant you use "EMPTY"?

@vishalhcl-5960 vishalhcl-5960 merged commit fd01a3a into HCL-TECH-SOFTWARE:ASA-2762 Nov 20, 2023
1 check failed
vishalhcl-5960 added a commit that referenced this pull request Nov 21, 2023
* handled the presence and proxy case (#120)
@vishalhcl-5960 vishalhcl-5960 deleted the ASA-2762 branch November 21, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants