-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeState
enum
#2966
Open
mr0re1
wants to merge
1
commit into
GoogleCloudPlatform:develop
Choose a base branch
from
mr0re1:node_state
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−2
Open
Add NodeState
enum
#2966
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ | |
import subprocess | ||
import sys | ||
import tempfile | ||
from enum import Enum | ||
import enum | ||
from collections import defaultdict, namedtuple | ||
from concurrent.futures import ThreadPoolExecutor, as_completed | ||
from contextlib import contextmanager | ||
|
@@ -127,7 +127,7 @@ def mkdirp(path: Path) -> None: | |
] = lambda self, data: yaml.representer.SafeRepresenter.represent_str(self, str(data)) | ||
|
||
|
||
class ApiEndpoint(Enum): | ||
class ApiEndpoint(enum.Enum): | ||
COMPUTE = "compute" | ||
BQ = "bq" | ||
STORAGE = "storage" | ||
|
@@ -1917,3 +1917,52 @@ def update_config(cfg: NSDict) -> None: | |
def scontrol_reconfigure(lkp: Lookup) -> None: | ||
log.info("Running scontrol reconfigure") | ||
run(f"{lkp.scontrol} reconfigure", timeout=30) | ||
|
||
|
||
class NodeState(str, enum.Enum): | ||
""" | ||
Representation of Slurm NODE_STATE | ||
|
||
For source of truth with 1-line explanation, see: | ||
https://github.com/SchedMD/slurm/blob/master/slurm/slurm.h#L980 | ||
For string representation to match, see: | ||
https://github.com/SchedMD/slurm/blob/master/src/plugins/data_parser/v0.0.42/parsers.c#L7449 | ||
|
||
NOTE: Copy of StrEnum implementation from python 3.11 stripped of extra features. | ||
Additionally support "unknown" items by defining `_missing_`. | ||
See tests for contract. | ||
""" | ||
def __new__(cls, value): | ||
return str.__new__(cls, value) | ||
|
||
@classmethod | ||
def _missing_(cls, value): | ||
o = str.__new__(cls, value) | ||
o._name_ = value | ||
return o | ||
|
||
def _generate_next_value_(name, *_): | ||
return name | ||
|
||
def __repr__(self): | ||
return self.__str__() | ||
|
||
# *** Base states | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will other node states like unknown or end be added or are they not needed? (from https://github.com/SchedMD/slurm/blob/master/slurm/slurm.h#L980) |
||
DOWN = enum.auto() # node in non-usable state | ||
IDLE = enum.auto() # node idle and available for use | ||
|
||
# *** "state flags" | ||
|
||
CLOUD = enum.auto() # node comes from cloud | ||
|
||
# Restore a DRAINED, DRAINING, DOWN or FAILING node to service | ||
# (e.g. IDLE or ALLOCATED). Used in slurm_update_node() request | ||
RESUME = enum.auto() | ||
|
||
POWER_DOWN = enum.auto() # manual node power down | ||
POWERED_DOWN = enum.auto() # node is powered down | ||
POWERING_DOWN = enum.auto() # node is powering down | ||
|
||
POWERING_UP = enum.auto() # node is powering up | ||
|
||
COMPLETING = enum.auto() # node is completing allocated job |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion seems to be failing in pre-commit, yet works fine while testing on my local env (based on the error message seems to be comparing this as 'DOWN' == 'NodeState.Down'). Maybe try running it again?