Add NodeState enum
#2966
Open
Add NodeState enum
#2966
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas1902
reviewed
Aug 22, 2024
| assert NodeState.DOWN != NodeState.POWER_DOWN | ||
| assert NodeState.DOWN != NodeState("dOwN") # case sensitive | ||
|
|
||
| assert f"{NodeState.DOWN}" == "NodeState.DOWN" |
There was a problem hiding this comment.
This assertion seems to be failing in pre-commit, yet works fine while testing on my local env (based on the error message seems to be comparing this as 'DOWN' == 'NodeState.Down'). Maybe try running it again?
| def __repr__(self): | ||
| return self.__str__() | ||
|
|
||
| # *** Base states |
There was a problem hiding this comment.
Will other node states like unknown or end be added or are they not needed? (from https://github.com/SchedMD/slurm/blob/master/slurm/slurm.h#L980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper enum to reduce usage of error-prone string literals (follow up action).