-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
564 add meta editing to the editor #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1485003 |
capital-G
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this is good as it is right now we can merge it :)
I added two more things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the frontendimplementation is done.
Missing steps:
Could you help me with that @capital-G ?
The idea:
On
Meta
tab we load all the meta data of the graph. Once we made updates, we can submit those in a summarized mutation. There is no subscription to keep it simple.Question:
I needed to add the AboutText, Displayname, ... to the
GraphDocument
Request. Do you think it's ok to extend it, or should we keep it clean and add a second request just for the Metadata?I'm wondering, because in theory one could add a lot of images to one of these texts, which would in bloat the size of the
GraphDocument
request a lot. This could possibly lead to a bottleneck increasing the time of loading the editor. Since the data is only necessary if Metadata needs to be exchanged.On the other hand, uploading incredibly big images to the
AboutText
would also put that load to the users. So maybe it's then just fair? :P